Change in ovirt-engine[master]: engine: Remove snapshot job remains open
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove snapshot job remains open
......................................................................
engine: Remove snapshot job remains open
The patch fixes few issues with snapshot remove implementation:
1. Commit ad1ac46bf56de9000f6562b7a5d3997326ed9121 has introduced
a change in commands with callback behavior regarding closing
the job. As a result of that patch, the responsibility of closing
the job associated with the command is passed to the callback.
2. The RemoveSnapshotCommand was missing a c'tor which associates
the cached command's context with its new instance while retrieved
by CoCo. Without this c'tor, the command couldn't monitor the job's
progress.
3. Although the command uses compensation, it doesn't introduce the
required c'tor for it.
Change-Id: Ia1331fc864e001a04c0ac1ec6a2b1f500e8fe59e
Bug-Url: https://bugzilla.redhat.com/1257529
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
2 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/47444
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1331fc864e001a04c0ac1ec6a2b1f500e8fe59e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org