Change in ovirt-engine[master]: core: detach/remove of domain with ovf stores
Liron Ar has submitted this change and it was merged.
Change subject: core: detach/remove of domain with ovf stores
......................................................................
core: detach/remove of domain with ovf stores
*When detaching a storage domain the engine should allow to detach it
even if it has disks that are used as the domain ovf store.
*When removing a storage domain, use the StorageDomainDao.remove method,
this method is currently being used by the ForceRemoveStorage flow and
cleans up anything associated with the domain.
As we allow to remove a domain with ovf stores, the domain disks should
be removed as well (handled by this sp).
This sp is heavier than the previous calls, but we are saving round
trips and removing storage domain is a rare scenario so we better
make sure that no leftovers are left by executing this sp rather than
take care of that ourselves and rely on bll CDA checks.
Change-Id: Icde56b54bd11c617056c819fcdbacac71753e264
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 26 insertions(+), 11 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde56b54bd11c617056c819fcdbacac71753e264
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server