Change in ovirt-engine[master]: restapi:fix overcommit accepts negative values
Roy Golan has submitted this change and it was merged.
Change subject: restapi:fix overcommit accepts negative values
......................................................................
restapi:fix overcommit accepts negative values
Memory over commit in rest API accepts non positive values.
the behavior was for all integers from zero and below
to set the memory over commit values to 200.
A validation was added for the memory over commit value
to reject all non positive integers.
(0 is a valid value)
Change-Id: I560d2275d3deefad960018c557f7c8b6b06bfb94
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301353
Signed-off-by: yquinn <yquinn(a)redhat.com>
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
Signed-off-by: yquinn <yquinn(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClusterOperationCommandBaseTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 86 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/59232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I560d2275d3deefad960018c557f7c8b6b06bfb94
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>