Change in ovirt-engine[ovirt-engine-4.0]: backend: generate default template's name for repo-image
Tal Nisan has submitted this change and it was merged.
Change subject: backend: generate default template's name for repo-image
......................................................................
backend: generate default template's name for repo-image
When importing an image from glance as a template, if the template's
name is not specified then we generate a default one in
ImportRepoImageCopyTaskHandler::createTemplate.
The problem with this is that ImportRepoImageCommand doesn't know about
this auto generated template's name (it's null in the command's
parameters), and then the template is logged as a part of the event as
"<UNKNOWN>", although it's created with its default name.
This patch generates that default template's name in the command instead
of the handler.
Change-Id: I7386be3d2c1254dc3df0dfab9c6c340b41a00aed
Bug-Url: https://bugzilla.redhat.com/1324780
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/58903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7386be3d2c1254dc3df0dfab9c6c340b41a00aed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>