Arik Hadas has submitted this change and it was merged. Change subject: core: extract balloon related code from vm-analyzer ...................................................................... core: extract balloon related code from vm-analyzer VmAnalyzer should (ideally) take a VM that was reported by VDSM, compare it to the previous information we have for that VM and analyze the difference. However, the analyzer currently does more than that and therefore is not easy to maintain. In this patch things that are related to monitoring balloon information are extracted from VmAnalyzer to a new class called BalloonMonitoring. The benefits are: 1. Less not-that-related code in VmAnalyzer and one less DAO to pass to it. 2. No use of static fields in VmAnalyzer (VmsMonitoring is already a singleton). 3. We get to the point where the dynamic data of the VM is persisted to the database faster - we eliminate a call to the DAO per-VM before the data is flushed into the database. This is now done after the important information is saved into the database. Change-Id: I3ccdab942209ea83f7803f4736cc49f371aa23dc Signed-off-by: Arik Hadas <ahadas@redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/BalloonMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 3 files changed, 142 insertions(+), 53 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/53717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ccdab942209ea83f7803f4736cc49f371aa23dc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>