Change in ovirt-engine[master]: webadmin: rm Version.OpEquality from DC model
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: rm Version.OpEquality from DC model
......................................................................
webadmin: rm Version.OpEquality from DC model
Replaced a call to Version.OpEquality with version.equals(version2),
as it's the standard Java way of doing things, and is easier to read.
This can be done since all the versions in getVersion().getItems()
are ultimately retrieved from
GetAvailableClusterVersionsByStoragePoolQuery, which is guaranteed to
return a List<Version> of non-null elements.
note that this also has a slight theoretical performance benefit, as
nullability is no longer checked on the first operand, but it's
doubtful that this will be be noticeable.
Change-Id: I9a02b827e4c2d1165cb7bdc69cb681df323d4c6f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a02b827e4c2d1165cb7bdc69cb681df323d4c6f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server