Tal Nisan has submitted this change and it was merged. Change subject: restapi: Handle incorrect user and group identifiers ...................................................................... restapi: Handle incorrect user and group identifiers Currently the RESTAPI doesn't check the format of user or group identifiers provided by the caller, it just tries to convert them assuming that they are hexadecimal characters. If this fails the exception isn't handled properly and stack trace is returned to the user. This patch changes the relevant resources so that they handle the exception and return the expected HTTP response codes. Change-Id: I1bf0139fd329f63e542d24b8d9f0115e8e7b6c80 Bug-Url: https://bugzilla.redhat.com/1281803 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> (cherry picked from commit 549ce58658212b749e02fdfe59beace518ab598a) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java 4 files changed, 36 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bf0139fd329f63e542d24b8d9f0115e8e7b6c80 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>