Allon Mureinik has submitted this change and it was merged. Change subject: engine: Move AddStorageDomainCommand.checkExistingStorageDomain ...................................................................... engine: Move AddStorageDomainCommand.checkExistingStorageDomain There is no reason to keep this method in the base class AddStorageDomainCommand just because it used by one of it's successors. I am moving it to AddExistingFileStorageDomainCommand. As a result of this change concreteCheckExistingStorageDomain() method can be removed from the base class. Change-Id: I2002f942d32aacf7bbcaa8b6caef3bb744d2dd48 Signed-off-by: Sergey Gotliv <sgotliv@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 2 files changed, 48 insertions(+), 52 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2002f942d32aacf7bbcaa8b6caef3bb744d2dd48 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server