Change in ovirt-engine[master]: core: handle 'image does not exists' error on remove hiberna...
Omer Frenkel has submitted this change and it was merged.
Change subject: core: handle 'image does not exists' error on remove hibernation
vols
......................................................................
core: handle 'image does not exists' error on remove hibernation vols
Introducing HibernationVolumesRemover class which removes hibernation
volumes with proper handling of 'image does not exists' error. This
error is not treated as an error, because the result is that the images
don't exists, as we wanted.
HibernationVolumesRemover class is being used by
RemoveVmHibernationVolumesCommand which is used by stop VM commands
(stop and shutdown) and run VM command (in resume from hibernation flow
in particular), eliminating the race described in bz 952603.
Change-Id: Ief52a20315b29660c7038eab1cc8dbbb4c4ded3e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmHibernationVolumesCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/HibernationVolumesRemover.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java
6 files changed, 161 insertions(+), 73 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief52a20315b29660c7038eab1cc8dbbb4c4ded3e
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server