Tomas Jelinek has submitted this change and it was merged. Change subject: engine: VM Linux Boot options aren't parsing properly ...................................................................... engine: VM Linux Boot options aren't parsing properly Steps to Reproduce: 1. have VM & init & kernel file on ISO domain 2. use Boot params => kernel/initrd params 3. put to initrd: "iso://rhel6.initrd " (without quotes, with space at the end) After starting the VM it runs for a moment and then it crashes with VDSM error: libvirtError('virDomainCreateXML() failed', conn=self). Fixed by adding validation of the user input (on frontend) and setting of VmBase parameters (on backend). Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54 Signed-off-by: Frantisek Kobzik <fkobzik@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872178 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NoTrimmingWhitespacesValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 102 insertions(+), 54 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/9550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com>