Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Fixes in non plugin console invocation ...................................................................... engine: Fixes in non plugin console invocation This patch introduces minor fixes in non plugin console invocation mainly related to internet explorer. Changes in backend: - mapping of attachment servlet changed to "console.vv", since IE ignores Attachment header - the filename parameter was removed as it has no effect in IE - no-cache header changed to max-age=0 header. With no-cache header IE fails to download the file if https is used - assume UTF-8 as the encoding of the incoming request in the attachment servlet Changes in frontend: - added spice plugin detection for IE Change-Id: I7fe6fbf274a9ac215e8f6593cc000f778a431928 Signed-off-by: Frantisek Kobzik <fkobzik@redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 8 files changed, 69 insertions(+), 54 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fe6fbf274a9ac215e8f6593cc000f778a431928 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com>