Alona Kaplan has submitted this change and it was merged.
Change subject: engine: handle bond options mode text value
......................................................................
engine: handle bond options mode text value
Bond options value can be both numeric and text value.
This patch adds support for the text value.
Longer description using lines' length under 72 chars.
Bond options comming from vds will be converted to
numeric values to store them uniformly.
Change-Id: If0fd5df3d02288b72e0b210849cc43a0ff74b507
Bug-Url:
https://bugzilla.redhat.com/1286967
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java
M
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/BondModeTest.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
3 files changed, 74 insertions(+), 46 deletions(-)
Approvals:
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/49724
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0fd5df3d02288b72e0b210849cc43a0ff74b507
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>