Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCommand to inherit from CommandBase ...................................................................... core: StorageJobCommand to inherit from CommandBase This patch changes StorageJobCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: I60263c3517a334f9b8308765fefbc4905bc3bb09 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AllocateImageGroupVolumeCommand.java 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60263c3517a334f9b8308765fefbc4905bc3bb09 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>