Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: fixing hostname validation
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: fixing hostname validation
......................................................................
packaging: setup: fixing hostname validation
engine-setup validates hostnames to avoid strange behaviours;
it's done via a regular expression.
Fixing it to avoid the match of '_' which is
not a valid character in a hostname according to RFC 952
An invalid hostname can cause strange behaviour interacting
with other components.
Change-Id: Id5c56bc5642bfb18629c1a0ad780e8a0e58a3531
Bug-url: https://bugzilla.redhat.com/1113974
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 98079e8c37e00349ce5b1f86d2501a15615a3339)
---
M packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/29759
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5c56bc5642bfb18629c1a0ad780e8a0e58a3531
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org