Change in ovirt-engine[master]: core: Handling DestroyVds's 'noVm error msg' after Cancel Mi...
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Handling DestroyVds's 'noVm error msg' after Cancel
Migration
......................................................................
core: Handling DestroyVds's 'noVm error msg' after Cancel Migration
This patch logs potential 'noVm message' after Cancel Migration's
DestroyVdsCommand
clean-up call at INFO instead of ERROR level.
In happy-day scenario, VDSM removes VM on target when migration job is aborted.
If something goes wrong (connection between hosts is down, VDSM/libvirt
does not do their job, etc.), the DestroyVdsCommand needs to be called on destination
to clean-up once Down VM report is received.
This patch does not remove the 'noVm error message' completely.
For the rare case, if source VDSM changes VM to UP before target's DOWN VM report is
received, the error is still being logged.
In that case, an INFO msg is logged explaining that missing VM must not be an error
and explaining when/why.
Proper clean-up on destination or logging if something goes really wrong has higher
priority before printing harmless error message.
Change-Id: Icd93048d785c298333f8e2df79008ee70c97bf98
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1275747
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyVmVDSCommandParameters.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java
3 files changed, 52 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd93048d785c298333f8e2df79008ee70c97bf98
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>