Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Fixed configured range validator
......................................................................
core: Fixed configured range validator
Configured range validator wouldn't add the constraint violation
of range to the context of the error message.
For that, reason when trying to add CPU QoS with out of bound
limit it wouldn't not add the range to the error message.
This problem was fixed by adding the constraint violation to the
context.
Change-Id: I7cefb4d8a114238b86ab187ae4119e6da68b0009
Bug-Url:
https://bugzilla.redhat.com/1220110
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ConfiguredRangeValidator.java
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/47433
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cefb4d8a114238b86ab187ae4119e6da68b0009
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>