Change in ovirt-engine[ovirt-engine-3.6]: frontend: Allow ':' in VmInit network name
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Allow ':' in VmInit network name
......................................................................
frontend: Allow ':' in VmInit network name
Created new VmInitNetworkNameValidation that adds support for ':' character in
addition to those supported by AsciiNameValidation.
Also fixed issue regarding highlighting the first run tab on invalid data.
Problem was in usage of the old name for the tab (FIRST_RUN) and incorrectly using
the new one (INITIAL_RUN_TAB).
Change-Id: I8691dec2d9cc5ff645e2b18a73f0f1a8cd118bf3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248975
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/VmInitNetworkNameValidation.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
5 files changed, 22 insertions(+), 9 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/45073
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8691dec2d9cc5ff645e2b18a73f0f1a8cd118bf3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org