Allon Mureinik has submitted this change and it was merged. Change subject: core: AddBricksToGlusterVolumeCommand redundancy ...................................................................... core: AddBricksToGlusterVolumeCommand redundancy AddBricksToGlusterVolumeCommand.canDoAction() checks that getParameters().getBricks() is not null or empty. Therefore, it's redundant to re-check it in the executeCommand() method. This patch fixes Coverity defect CID 1311883. Change-Id: Idff9d7d7c1ac04c23de64debac6ae652b2780dc7 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff9d7d7c1ac04c23de64debac6ae652b2780dc7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: automation@ovirt.org