From Shlomo Ben David <sbendavi@redhat.com>:
Shlomo Ben David has submitted this change and it was merged. Change subject: Fix missing patchset ...................................................................... Fix missing patchset If someone press the 'rebase' button or add a comment it will run the hook dispatcher and it will take some time (few seconds) to finish, while during that time the 'rebase' button remains available and allows to press on it again. This behaviour cause patches to disappear. Example: current patch: #5 ==> clicked on the rebase button (you should be moved to patch #6) ==> clicked on the rebase button again (you are now on patch #7) while patch #6 isn't exist. Added code to catch the 'rebase' or added comments action and skip the rest of the checks. In Addition: - Rewrite the logging logic - Fixed some pep8 errors - Removed/Added some function doc strings Change-Id: Ie797a8dd8e7b5aa1415e668bb430ff65ed62ff52 Jira-ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1192 Signed-off-by: Shlomi Ben-David <sbendavi@redhat.com> --- M hooks/hook-dispatcher 1 file changed, 121 insertions(+), 77 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Anton Marchukov: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie797a8dd8e7b5aa1415e668bb430ff65ed62ff52 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi@redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk@redhat.com> Gerrit-Reviewer: Barak Korren <bkorren@redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky@redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi@redhat.com>