Change in ovirt-engine[master]: userportal: Enable context-sensitive help in dialogs
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Enable context-sensitive help in dialogs
......................................................................
userportal: Enable context-sensitive help in dialogs
This patch enables context-sensitive help feature for UserPortal dialogs.
UserPortalConfigurator will fetch "UserPortalDocumentationPath.csv"
file from following location:
http(s)://<host>:<port>/<DocsURL>/<locale>/UserPortalDocumentationPath.csv
This is similar to WebAdmin's "DocumentationPath.csv" file location, but
with different file name for UserPortal.
After receiving CSV file content, UserPortalConfigurator.eventRaised()
method method will call DocumentationPathTranslator.init() to initialize
modelHashName -> contextSensitiveHelp mappings.
When the CSV file cannot be retrieved, application will simply hide the
context-sensitive help button within the given dialog. See
AbstractModelBoundPopupPresenterWidget.updateHashName() method
for details on logic that updates help button availability.
This patch also adds "HTTP response OK" check in Configurator.fetchFile()
method.
Change-Id: I8c84a6fb4875049669b18753f9246cfe3aaefd8d
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
3 files changed, 36 insertions(+), 32 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c84a6fb4875049669b18753f9246cfe3aaefd8d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>