Change in ovirt-engine[master]: core: disk migrate - avoid ctor init on last task handler
Daniel Erez has submitted this change and it was merged.
Change subject: core: disk migrate - avoid ctor init on last task handler
......................................................................
core: disk migrate - avoid ctor init on last task handler
LiveMigrateDiskCommand - avoid initialization on constructor
in case of last task handler:
* No need to fetch un-needed stale data after last task completion.
* Prevent an NPE on getVm() -> getVmsListForDisk()
[as getImageGroupId() can be null in case of deleting the source
disk before the last task (deleteImage) has been completed].
Change-Id: I4c8f14fdcc5e7db3cca41d2ce2e37e97a034ca23
Bug-Url: https://bugzilla.redhat.com/971022
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22882
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c8f14fdcc5e7db3cca41d2ce2e37e97a034ca23
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server