Change in ovirt-engine[master]: engine:Remaining disks of deleted VM will be ILLEGAL.(#82205...
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
......................................................................
engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
When removing a VM, the VM images are removed from the VDSM
and the DB.
If VDSM fails to start a task for deleting a specific image,
it throws an exception and the image is not removed from the engine DB.
This results a bug which is reflected, when user sees part of the VM
disks, which were not be able to delete from the VDSM, in the
disk main tab.
The proposed solution is that we leave the remaining disks in the setup
with ILLEGAL state and remove all the rest of the VM.
Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 67 insertions(+), 7 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server