Change in ovirt-engine[master]: webadmin: changed the list of fields which can not be overri...
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: changed the list of fields which can not be overridden
......................................................................
webadmin: changed the list of fields which can not be overridden
There are the following types of fields in instance types:
- the ones which are taken from it but the user can override them (e.g. defaults)
- the ones which the user can not override
This patch reduces the num of fields which can not be overridden to contain
only the really most important ones. This avoids the situation that the user will
have to have instance types like: "big with soundcard", "big with smardcard
and
soundcard" etc.
The list is now significantly smaller, contains only:
- memory size
- num of sockets/cores per socket
- HA
- migration model/downtime
- priority
- balloon/min allocated memory
The specific UI changes include:
- remove the chain icon from fields which are not considered to be "marked"
anymore
- remove the specific fields from
InstanceTypeAttachDetachManager.detachableModels so it will not detach the VM
from instance type if changed
Change-Id: I7fc831f0a0656f8eaa92fe3509b03c8ac1b71fb9
Bug-Url: https://bugzilla.redhat.com/1149663
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeAttachDetachManager.java
3 files changed, 14 insertions(+), 59 deletions(-)
Approvals:
Tomas Jelinek: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fc831f0a0656f8eaa92fe3509b03c8ac1b71fb9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server