Change in ovirt-engine[master]: core: Remove AbstractDiskVmCommand#filterConnectionsByStorag...
From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. (
https://gerrit.ovirt.org/79524 )
Change subject: core: Remove AbstractDiskVmCommand#filterConnectionsByStorageType
......................................................................
core: Remove AbstractDiskVmCommand#filterConnectionsByStorageType
Grouping the lun's connections by their storage type is redundant, as
the connections themselves are not used.
The only part of the result of the method used is the types
themselves, which can be extracted much more easily.
Change-Id: If69cf06d13332200a222c1b1af77ef20ffe592b6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java
D
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommandTest.java
2 files changed, 4 insertions(+), 104 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79524
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If69cf06d13332200a222c1b1af77ef20ffe592b6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>