Change in ovirt-engine[master]: webadmin: refactored volume activity status column
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: refactored volume activity status column
......................................................................
webadmin: refactored volume activity status column
Removed the hard coded GlusterVolumeEntity from all the
volume activity related cells and used GlusterTaskSupport instead.
So that the columns/cells can be re-used for showing the
activities related bricks as well.
GlusterVolumeEntity and GlusterBrickEntity is inherited
from GlusterTaskSupport.
Used a diffrent icon for the menu cell to have better visibility.
Also the activity cell will be available if the task status is not-null
and not UNKNOWN.
Change-Id: I85df6e5d2071f8ff1cc5f94ace90edfb0fff471e
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/MenuCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityCompositeCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivitySeperatorCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusColumn.java
7 files changed, 47 insertions(+), 32 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85df6e5d2071f8ff1cc5f94ace90edfb0fff471e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server