
From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: core, webadmin: Imported VMs have default maxMemory ...................................................................... core, webadmin: Imported VMs have default maxMemory ... instead of maximum of allowed value as defined in *MaxMemorySizeInMB configuration values. The default is 4x value of memory size and it is maximum suggested value of maxMemory. Default value of ConfigValues.VM64BitMaxMemorySizeInMB was changed to 4194304 to match the current value in vdc_options table. After this change default values of all *MaxMemorySizeInMB options should match values in vdc_options. Reasons for not exceeding suggested value: * QEMU goes through nested loop of size of the maxMemory at its start. Large value of maxMemory can make QEMU to start for a longer time. * We want hot plugged memory to be also hot unpluggable. This requires guest kernel to consider hotplugged memory to be 'movable'. Kernel may be unstable if movable part of memory is significantly larger than non-movable part of the memory. * On PowerPC platform continuous block of non-movable memory of size 1/64 of the max memory needs to be allocated for each VM. Bug-Url: https://bugzilla.redhat.com/1411844 Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCommonUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 4 files changed, 16 insertions(+), 10 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>