Juan Hernandez has submitted this change and it was merged. Change subject: Support strings as parameters of XML readers and writers ...................................................................... Support strings as parameters of XML readers and writers Currently the constructor XML reader and writer classes require IO objects. But may use cases require passing a string, so there are multiple places where a "StringIO" object has to be created in order to satisfy the contracts of the XML readers and writers. To simplify those use cases this patch improves the XML readers and writers so that they support also strings. If an IO object isn't provided, then the XML readers and writers will create "StringIO" objects and use them internally. Change-Id: I93e3e2078002a8ad387e0f3ffacb532b586eb52a Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/ext/ovirtsdk4c/ov_xml_reader.c M sdk/ext/ovirtsdk4c/ov_xml_writer.c M sdk/lib/ovirtsdk4.rb M sdk/lib/ovirtsdk4/service.rb M sdk/spec/action_reader_spec.rb M sdk/spec/fault_reader_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/spec_helper.rb M sdk/spec/vm_reader_spec.rb M sdk/spec/vm_writer_spec.rb M sdk/spec/writer_spec.rb M sdk/spec/xml_reader_spec.rb M sdk/spec/xml_writer_spec.rb 14 files changed, 289 insertions(+), 392 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e3e2078002a8ad387e0f3ffacb532b586eb52a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>