Change in ovirt-engine[master]: core: AttachNetworkToClusterInternalCommandTest stubbing
Tal Nisan has submitted this change and it was merged.
Change subject: core: AttachNetworkToClusterInternalCommandTest stubbing
......................................................................
core: AttachNetworkToClusterInternalCommandTest stubbing
Remove TestAttachNetworkToClusterCommand and replace it with a standard
@Spy instance.
In order to accomplish this, AuditLogableBase#getNetworkClusterDao and
AuditLogableBase#getNetworkDao had to be made public like the other
getXYZDao methods in that class.
Note that they will be removed and replaced with injection at the end of
this series anyway.
Change-Id: I4db8895ed8ce9bd564c92cdad4eb21d8495fa35e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommandTest.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
5 files changed, 17 insertions(+), 56 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64786
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4db8895ed8ce9bd564c92cdad4eb21d8495fa35e
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>