Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: editConfigContent: compare strings ...................................................................... packaging: setup: editConfigContent: compare strings Make editConfigContent compare values as strings when deciding if value was changed. Without this change, an excessive comment line will be added to /var/lib/pgsql/data/postgresql.conf after comparing int(150) and str(150). Change-Id: Ia747d05416ff0ed1fbd74f0d4cce2c9f6b621755 Signed-off-by: Yedidyah Bar David <didi@redhat.com> --- M packaging/setup/ovirt_engine_setup/util.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia747d05416ff0ed1fbd74f0d4cce2c9f6b621755 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com>