Change in ovirt-engine[master]: core: VmReplicateDiskFinish on SyncImageData failure

Daniel Erez has submitted this change and it was merged. Change subject: core: VmReplicateDiskFinish on SyncImageData failure ...................................................................... core: VmReplicateDiskFinish on SyncImageData failure Requirements: * VmReplicateDiskFinish should be sent on SyncImageData failure. * Further rollback should be prevented on VmReplicateDiskFinish failure. * Disk should always be unlocked after failure. Implementation details: * Added 'preventRollback' method to TaskHandlerCommand interface. * Implemented 'preventRollback' on LiveMigrateDiskCommand. * Called 'revertTask' on 'endWithFailure' to ensure revert on task failure. Change-Id: I6c25b02cb0c2bd78b012dd3e3654caa43f5141d6 Bug-Url: https://bugzilla.redhat.com/961423 Signed-off-by: Daniel Erez <derez(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java 5 files changed, 65 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c25b02cb0c2bd78b012dd3e3654caa43f5141d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;