Change in ovirt-engine[master]: core: Remove server hooks correctly
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Remove server hooks correctly
......................................................................
core: Remove server hooks correctly
According to findbugs the "deletedServerHooks" map used in the
"GlusterHookSyncJob" class is useless, as it is populated but never
queried:
Useless object created
Our analysis shows that this object is useless. It's created and
modified, but its value never go outside of the method or produce any
side-effect. Either there is a mistake and object was intended to be
used or it can be removed.
This analysis rarely produces false-positives. Common false-positive
cases include:
- This object used to implicitly throw some obscure exception.
- This object used as a stub to generalize the code.
- This object used to hold strong references to weak/soft-referenced
objects.
Bug kind and pattern: UC - UC_USELESS_OBJECT
This patch changes the sync job so that the unused object is removed.
Change-Id: Icb7de1c5a4bf38f641960baf4b6cf3dd86b0b850
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb7de1c5a4bf38f641960baf4b6cf3dd86b0b850
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org