From Oved Ourfali <oourfali@redhat.com>:
Oved Ourfali has submitted this change and it was merged. Change subject: webadmin,userportal: Improve dialog cleanup logic ...................................................................... webadmin,userportal: Improve dialog cleanup logic This patch ensures that dialog related resources (Views and Models) are cleaned up when both of the following conditions are satisfied: 1, a dialog has just been closed 2, there are no more active (visible) dialogs left This fixes issues where one dialog triggers another dialog, and we cannot simply clean up former dialog's Model as it might be needed later on. Change-Id: Iedd16549f19ea3630bc59f56e6a1a2f880239b27 Bug-Url: https://bugzilla.redhat.com/1368101 Bug-Url: https://bugzilla.redhat.com/1391466 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedd16549f19ea3630bc59f56e6a1a2f880239b27 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>