Change in ovirt-engine[master]: webadmin: Parameterize ImportNetworksModel and related classes
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Parameterize ImportNetworksModel and related classes
......................................................................
webadmin: Parameterize ImportNetworksModel and related classes
Parameterized generic instances of ListModel in ImportNetworksModel,
as well as the corresponding view and widget used in that view (and
nowhere else at the moment, which made things easier).
ExternalNetwork is changed to extend Model instead of EntityModel (as
it used no special capabilities of EntityModel).
Change-Id: I4d1e6e409edc794baa799807268755105f8e21fa
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ExternalNetwork.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
5 files changed, 91 insertions(+), 92 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1e6e409edc794baa799807268755105f8e21fa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server