2:37 a.m.
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: infrastructure for VmDevices in next run VM snapshot
......................................................................
core: infrastructure for VmDevices in next run VM snapshot
Added an infrastructure for including VmDevices in a snapshot
of type 'Next Run'. This should allow enabling/disabling of
devices while VM is running (i.e. similarly to VM properties that
are editable on a non-running VM, a warning message [1] is being
shown upon editing a VM device status).
* Created a new annotation interface for devices:
'EditableDeviceOnVmStatusField'.
* VmHandler - initialized mUpdateVmsStatic with those fields.
* UpdateVmCommand - passed a list of devices for next run
when creating the snapshot with new configuration.
* GetVmUpdatesOnNextRunExistsParameters now gets an instance of
VmManagementParametersBase in ctr [since the new annotation
(EditableDeviceOnVmStatusField) will be used in this
parameters file].
* GetVmUpdatesOnNextRunExistsQuery - added a validation for
updating VM devices.
* Modified client invocations accordingly.
[1] "Some of the changes will be applied after the NEXT RESTART"
Change-Id: I4e7add4e7e09fe8d6d1f93f0d2b96795d838efa2
Bug-Url: https://bugzilla.redhat.com/1035289
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableDeviceOnVmStatusField.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmUpdatesOnNextRunExistsParameters.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
15 files changed, 290 insertions(+), 104 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e7add4e7e09fe8d6d1f93f0d2b96795d838efa2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server