Change in ovirt-engine[ovirt-engine-4.0]: core: Cluster version update locks all VMs
Tal Nisan has submitted this change and it was merged.
Change subject: core: Cluster version update locks all VMs
......................................................................
core: Cluster version update locks all VMs
Updating cluster version needs to call UpdateVmCommand to update VM
devices (https://gerrit.ovirt.org/#/c/55636/).
This patch adds locking of all necessary VMs in the
UpdateClusterCommand if version is being changed. Locks are passed
to UpdateVmCommand by setting LockProperties scope to None.
Backport only change: initialization of UpdateClusterCommand#oldGroup
was moved from validate() method to init() + tests. Inspired by patch
https://gerrit.ovirt.org/#/c/50756.
Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced
Bug-Url: https://bugzilla.redhat.com/1349526
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 75 insertions(+), 33 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60995
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>