Arik Hadas has submitted this change and it was merged. Change subject: core: fix updateVmRunTimeInfo ...................................................................... core: fix updateVmRunTimeInfo 1. Rename VmAnalyzer#updateVmRunTimeInfo to updateVmDynamicData as it updates the runtime information in VmDynamic part of the VM. 2. Extract the code that fetches the VM from the DB (it might be that the VM is not running on the monitored host but exists in the DB) as it should not be part of this method. 3. Set the dynamic data to save in this method as it should be part of its responsibility and change the method to be void. Change-Id: I792b1467c011abade985fce6ba1d618903ef5804 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 17 insertions(+), 22 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792b1467c011abade985fce6ba1d618903ef5804 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>