Change in ovirt-engine[master]: engine: HostSetupNetworks- simplify and fix bugs in slaves v...
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: HostSetupNetworks- simplify and fix bugs in slaves validation
......................................................................
engine: HostSetupNetworks- simplify and fix bugs in slaves validation
The bug was- the validation failed even if the attachment was removed from
the slave.
And while at it, simplified the code.
Change-Id: I7637ee843be630c916c290952a9ffd3d26ec9105
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
3 files changed, 47 insertions(+), 104 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7637ee843be630c916c290952a9ffd3d26ec9105
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org