Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove ListUtils.getAddedElements ...................................................................... core: Remove ListUtils.getAddedElements ListUtils.getAddedElements has the same functionality as the standard org.apache.commons.collections.CollectionUtils.subtract, and thus can easily be removed for sake of reducing the size of the codebase and focusing on oVirt's business logic. In the only place it was used, it was used to subtract between two sets with a maximal size of 2, so performance is hardly an issue here. Change-Id: Ia7a0bf9c1f897fca7eafeb279bc41776c794526f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java 3 files changed, 3 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a0bf9c1f897fca7eafeb279bc41776c794526f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: anmolbabu <anbabu@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>