Arik Hadas has submitted this change and it was merged.
Change subject: core: fix remove vm from export domain
......................................................................
core: fix remove vm from export domain
The injection of BackendInternal broke import from export domain.
The problem was that in the constructor of RemoveVmCommand we called
getVm() that invokes a query to get the VM from the export domain.
However, BackendInternal is not injected at this stage so NPE is
thrown. The solution is to extract the initialization code in
RemoveVmCommand into the 'init' method that is called after the
object is constructed, including its injected fields.
Change-Id: Ieb4cd5f4b301d73a996ad4acc505fd8bb42e29fd
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit
https://gerrit.ovirt.org/48576
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb4cd5f4b301d73a996ad4acc505fd8bb42e29fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>