9:25 a.m.
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: StorageListModel: refactoring storage prepare for edit.
......................................................................
webadmin: StorageListModel: refactoring storage prepare for edit.
As preparing storage for editing in StorageListModel has similiar logic
through File and Block storage and all of their types, and currently
there is a "prepare" method for each of those types- it is now
consolidated into each model, with the proper differences divided
between the models.
prepareStorageForEdit will replace all of these "prepareXstorageForEdit"
and let the proper model to do the rest of the work, divided through SAN and
FILE storage types.
Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LocalStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
7 files changed, 177 insertions(+), 224 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Fred Rolland: Looks good to me, but someone else must approve
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/38128
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server