Tal Nisan has submitted this change and it was merged. Change subject: core: ignore noVm error for internal destroy ops ...................................................................... core: ignore noVm error for internal destroy ops In Icd93048d78 we changed the engine to ignore errors of type noVm when they arrive from the destination host after cancel migration. Actually this is a particular instance of a more general problem - if we ask to destroy the VM and it is not there anymore, does it really mean that the opreation fails? Sure, for user-initiated operations it makes some sense to report these errors so users will know that the operation they asked for failed (and this is also debateable), but for internal operations - it is not interesting for anyone to know about this "problem". Therefore, setting ignoreNoVm to true for all destroy operations that are done from the monitoring. Change-Id: Ibc43d294804b0dd4070c0a08af6bba40652e1281 Bug-Url: https://bugzilla.redhat.com/1290361 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyVmVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java 3 files changed, 34 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc43d294804b0dd4070c0a08af6bba40652e1281 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>