Change in ovirt-engine[master]: webadmin: prevent class cast exception on import vm
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: prevent class cast exception on import vm
......................................................................
webadmin: prevent class cast exception on import vm
This patch is a workaround for a problem with StorageDisksListModel that
cause class-cast exception: in ImportVmFromExportDomainModel we set the
items in StorageDisksListModel to StorageDomains. However, in
StorageDisksListModel#updateActionAvailability we expect the
getSelectedItems method to return DiskImages.
Probably something went wrong in b13dc92e where StorageDisksListModel
was introduced in ImportVmFromExportDomainModel. This patch is only a
workaround that eliminates the error by clearing the storage-domain
before loading new ones so the previous selected item will be null and
we won't get that exception. Proper solution should be introduced
separately.
Change-Id: I28f9eee614ba5e6eeef9f8aa88337aab9a90a2f9
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/40056
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28f9eee614ba5e6eeef9f8aa88337aab9a90a2f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server