Simone Tiraboschi has submitted this change and it was merged. Change subject: jsonrpc: python jsonrpcvdscli instead of vdsClient ...................................................................... jsonrpc: python jsonrpcvdscli instead of vdsClient Use python jsonrpcvdscli instead of vdsClient for ancillary commands on bash scripts. Adding unit test for the vm.conf parsing code based on pytest. Adding the initial pytest configuration. Change-Id: I4880eb94dfabe9628d34687a97febe3b1c6fd969 Bug-Url: https://bugzilla.redhat.com/1393918 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com&gt; Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt; --- M .gitignore M Makefile.am M ovirt-hosted-engine-setup.spec.in M po/POTFILES.in A pytest.ini M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/vdsm_helper.py A src/ovirt_hosted_engine_setup/vm_test.conf A src/ovirt_hosted_engine_setup/vmconf.py A src/ovirt_hosted_engine_setup/vmconf_test.py M src/plugins/gr-he-upgradeappliance/vm/runvm.py 12 files changed, 534 insertions(+), 55 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4880eb94dfabe9628d34687a97febe3b1c6fd969 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt; Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com&gt; Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com&gt; Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt; Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;