Daniel Erez has submitted this change and it was merged. Change subject: webadmin: display tool-tip for disabled editors ...................................................................... webadmin: display tool-tip for disabled editors Display 'Model -> getChangeProhibitionReasons()' as a tool-tip when applicable: * 'UiCommonEditorVisitor -> onIsChangablePropertyChange', passing to 'setEnabled' the 'changeProhibitionReasons' string list * 'AbstractValidatedWidgetWithLabel -> setEnabled', set widget's title with the first hint string (similar to 'AbstractValidatedWidget -> markAsInvalid'). [we might want to extend it to a 'multi disability hints tool-tip later on] Change-Id: Id74f1f082219fbd4d0042ec08f926b8861500745 Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasEnabled.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java 4 files changed, 60 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74f1f082219fbd4d0042ec08f926b8861500745 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>