Liron Aravot has submitted this change and it was merged. Change subject: core: GetAllDisksByVmIdQuery - improved performance ...................................................................... core: GetAllDisksByVmIdQuery - improved performance Currently when executing GetAllDisksByVmIdQuery, all the vm disks are queried using the GetDisksVmGuid stored procedure and then the vm device for each disk is being loaded to complete to queried data. This can cause to mass of loads that could be prevented, GetDisksVmGuid already performs join with vm_device table so that records could be just returned. Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Bug-Url: https://bugzilla.redhat.com/1130065 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/create_views.sql 5 files changed, 40 insertions(+), 47 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Anonymous Coward #1000524 Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server