Omer Frenkel has submitted this change and it was merged. Change subject: core: snapshot's memory volume type by storage type ...................................................................... core: snapshot's memory volume type by storage type The volume for the memory dump which is saved as part of live snapshot with memory was created as 'preallocated' volume, in order to be suitable for all storage types as 'preallocated' and 'raw' volumes are supported by all storage types. This patch changes it - now the type of the memory dump volume is determined according to the storage type, exactly as it is done for hibernation's memory volume: in file-based storage it is created as 'sparse' and in block based storage as 'preallocated' (always as 'raw'), as it turned out to be much faster to create sparsed volume on file-based storage. A proper conversions will need to be done at export & import operations according to the destination storage type. Change-Id: I1c0031c4257576d16162ef09bb5086b5ee784132 Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c0031c4257576d16162ef09bb5086b5ee784132 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server