Daniel Erez has submitted this change and it was merged.
Change subject: core: ReplicateDisk - prevent rollback on engine restart
......................................................................
core: ReplicateDisk - prevent rollback on engine restart
VmReplicateDiskFinishTaskHandler:
Rollback should be prevented on VmReplicateDiskFinish success,
but we can't rely on the command's returnValue since
it's not persistent. Instead, to make sure rollback
is prevented on restart, query the DB to verify that
the disk indeed moved to the target storage domain.
Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7
Bug-Url:
https://bugzilla.redhat.com/958848
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/14441
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>