Tal Nisan has submitted this change and it was merged. Change subject: core: Change existing disk validation CDA message in case of null disk alias ...................................................................... core: Change existing disk validation CDA message in case of null disk alias When try to import a VM which one or more of it's disks already exist on the system there's a CDA message containing the disk aliases of the existing disks, the aliases are taken from the disks in the export domian but in case the alias is null (mainly in backups of versions <V3.0, P2V, V2V etc..) the alias was displayed as a blank string, the CDA message was change and in case the alias is null the alias will be taken from the disk in the system Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7 Signed-off-by: Tal Nisan <tnisan@redhat.com> Bug-Url: https://bugzilla.redhat.com/928864 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java 2 files changed, 32 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ayal Baron <abaron@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server