Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix findbugs 'ignore java.lang.Exception' warning ...................................................................... webadmin: Fix findbugs 'ignore java.lang.Exception' warning DynamicTabContainerPresenter.setInSlot method override repeats some code from superclass method (TabContainerPresenter.setInSlot) simply because it doesn't allow easy extension of its logic. This patch fixes 'ignore java.lang.Exception' findbugs warning by logging the exception via client-side logger infrastructure. Change-Id: I414216bdbf0419862a6beeebf037ec559d608290 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I414216bdbf0419862a6beeebf037ec559d608290 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server