Juan Hernandez has submitted this change and it was merged. Change subject: core, restapi: Support adding permission using role name ...................................................................... core, restapi: Support adding permission using role name Currently the operations to add permissions require the identifier of the role: POST /vms/{vm:id}/permissions <permission> <role id="00000000-0000-0000-0000-000000000001" /> <group id="..."/> </permission> This patch adds the capability to use role names as well: POST /vms/{vm:id}/permissions <permission> <role> <name>UserVmManager</name> </role> <group id="..."/> </permission> Change-Id: I74f22e9bebbc102a45b76e9c62cc44961edadfbc Bug-Url: https://bugzilla.redhat.com/1152989 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java 4 files changed, 157 insertions(+), 94 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f22e9bebbc102a45b76e9c62cc44961edadfbc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ori Liel <oliel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: automation@ovirt.org